Specify build backend and project metadata in pyproject.toml #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 182 182
Branches 33 33
=========================================
Hits 182 182 ☔ View full report in Codecov by Sentry. |
maxrjones
changed the title
andersy005
reviewed
Oct 6, 2022
weiji14
approved these changes
Oct 6, 2022
Comment on lines
+54
to
+57
| [tool.setuptools_scm] | ||
| version_scheme = 'post-release' | ||
| local_scheme = 'dirty-tag' | ||
| fallback_version = "999" |
There was a problem hiding this comment.
Just a note that this might need to change if/when a 'Publish to PyPI' GitHub Actions is created, but ok as is for now.
Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Anderson Banihirwe <[email protected]>
|
Leaving a note that I removed the changes relevant to #99 from this PR in order to isolate those changes and the necessary discussion to a smaller PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In accordance with the following PEPs, this PR specifies the build system settings and project metadata in pyproject.toml.